-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go] More idiomatic godoc comments #10044
Conversation
@NathanBaulch thanks for the PR. Is there a URL to the official godoc comment guidelines? |
This blog post is the closest I've seen to something official. It points out a few packages in the Go standard library that are exemplars of good inline docs. This, along with the official godoc utility and documentation rendered in GoLand are what I based my changes on. |
For some reason AppVeyor had an issue with the csharp generator (which I didn't touch) and I wasn't sure how to force a retry, so instead I've pushed some template readability/consistency tweaks. |
For appveyor failure, please ignore it as we've been seeing build failures from appveyor intermittently. |
Thanks for the link. If no further feedback from anyone, I'll merge it over the weekend. Thanks again for the PR. |
I've just added support for marking non-path operation parameter funcs deprecated. This required a change to the generator code since the parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ 🏅
Sorry for the moving target on this PR. |
The generated godoc comments are not idiomatic and produce ugly formatting when using the godoc tool and in popular IDEs like GoLand.
notes
)@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.3.x
,6.0.x