Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][aspnetcore] Documentation : operationModifier can't be partial #4829

Closed
tmakin opened this issue Dec 18, 2019 · 2 comments
Closed

[BUG][aspnetcore] Documentation : operationModifier can't be partial #4829

tmakin opened this issue Dec 18, 2019 · 2 comments

Comments

@tmakin
Copy link

tmakin commented Dec 18, 2019

Description

Very minor issue.

The help text for aspnetcore generator suggests that the operationModifier option can be partial. This is not possible in c# and is not implemented in the generator (it's just the help text that is wrong)
https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AspNetCoreServerCodegen.java#L73

openapi-generator version

4.2.2

Steps to reproduce

Using CLI:

> openapi-generator config-help -g aspnetcore

...
 operationModifier
            Operation Modifier can be virtual, abstract or partial (Default: virtual)
...
Suggest a fix

Update help text as follows:
private CliOption operationModifier = new CliOption(OPERATION_MODIFIER, "Operation Modifier can be virtual or abstract");

@auto-labeler
Copy link

auto-labeler bot commented Dec 18, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

wing328 pushed a commit that referenced this issue Aug 3, 2020
* fixed a typo issue in aspnetcore generator #4829

* solved an issue with integration tests using WebApplicationFactory

* updated aspnetcore samples impacted by the change
@wing328 wing328 closed this as completed Aug 3, 2020
@wing328
Copy link
Member

wing328 commented Aug 3, 2020

Thanks for the fix by @Sshnyari

@tmakin please pull the latest master or snapshot version to give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants