Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REQ] //eslint-disable should be /* eslint-disable */ #4539

Closed
sreichi opened this issue Nov 19, 2019 · 0 comments · Fixed by #4540
Closed

[REQ] //eslint-disable should be /* eslint-disable */ #4539

sreichi opened this issue Nov 19, 2019 · 0 comments · Fixed by #4540
Labels
Enhancement: Feature

Comments

@sreichi
Copy link
Contributor

sreichi commented Nov 19, 2019 •
edited
Loading

When using the generated typescript-fetch client i allways get warnings in my console telling
me I have unused vars in my generated clients. Therefore i had a look and it is true. There are unused vars. But there is also a //eslint-disable comment at the top of the file. The Problem is that eslint requrires a different format for disables.

I tested it by just replacing //eslint-disable with /* eslint-disable */ and voilà the warning is gone.

I would recommend to change //eslint-disable into /* eslint-disable */
sreichi added a commit to sreichi/openapi-generator that referenced this issue Nov 19, 2019
@sreichi
FIXES OpenAPITools#4539 replace line comment with block comment
3699286 
eslint requires you to use a block comment for ignoring whole files.
@sreichi sreichi mentioned this issue Nov 19, 2019
Merged
5 tasks
macjohnny pushed a commit that referenced this issue Nov 21, 2019
@sreichi @macjohnny
[TS] replace line comment with block comment (#4540)
4747340 
* FIXES #4539 replace line comment with block comment

eslint requires you to use a block comment for ignoring whole files.

* changed comment style in other templates

* generated samples

* generated openapi3 samples

* Revert "generated openapi3 samples"

This reverts commit 98af3df

* generated missing samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TS] replace line comment with block comment sreichi/openapi-generator
1 participant
@sreichi