[BUG] PHP generator produce a invalid php file when shema have an enum with default value.

[etremblay]

Description

PHP generator produce a invalid php file when shema have an enum with default value.

PHP Warning:  Use of undefined constant TYPE_MOVE - assumed 'TYPE_MOVE' (this will throw an Error in a future version of PHP)

Tested with php 7.4

openapi-generator version

5.1.1, 5.2.1, master

OpenAPI declaration file content or url

openapi: 3.0.0
info:
  title: 'Enum Bug'
  version: latest
paths:
  '/':
    get:
      operationId: demoBug
      responses:
        '200':
          description: Success
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/MoveMovement'
components:
  schemas:
    MoveMovement:
      required:
        - type
      properties:
        type:
          type: string
          default: MOVE
          enum:
            - MOVE

Generation Details

docker run --rm  -v ${PWD}:/local --user "${USER_ID}:${GROUP_ID}" openapitools/openapi-generator-cli:latest generate -i /local/model.yaml -g php -o /local/php

Steps to reproduce

Generate php model with an enum property with default value

The model constructor will have invalid php code

    const TYPE_MOVE = 'MOVE';
    
    ...

    public function __construct(array $data = null)
    {
        $this->container['type'] = $data['type'] ?? TYPE_MOVE;
    }

should be

    $this->container['type'] = $data['type'] ?? self::TYPE_MOVE;

Suggest a fix

https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPhpCodegen.java

    @Override
    public String toEnumDefaultValue(String value, String datatype) {
        return "self::" + datatype + "_" + value;
    }

[wing328]

Can you please file a PR with the suggested fix?

[etremblay]

@wing328 Now I did #10273