Move openamp demos #44
Conversation
examples/legacy_apps/system/generic/machine/zynqmp_r5/linker_remote.ld
Outdated
Show resolved
Hide resolved
tnmysh
force-pushed
the
move_openamp_demos
branch
from
16531f5 to
e042794
Compare
tnmysh
force-pushed
the
move_openamp_demos
branch
from
e042794 to
dcc9284
Compare
tnmysh
force-pushed
the
move_openamp_demos
branch
from
dcc9284 to
ca00345
Compare
There was a problem hiding this comment.
This PR looks good but why do we call the folder legacy_apps?
When I read legacy app, I'm thinking of something old that might not even work - but maybe is just me :)
Can we call the folder generic_samples, or just generic (since it's already in examples).
Also, not very clear for me how these samples work?
Do we have a Linux-Zephyr communication?
Can we add, for each sample a README - like we have now here, for each app.
I see the comment from the start of each sample (like here) but IMO is not enough.
| #define SHUTDOWN_MSG 0xEF56A55A | ||
|
|
||
| #define LPRINTF(format, ...) printf(format, ##__VA_ARGS__) | ||
| //#define LPRINTF(format, ...) |
There was a problem hiding this comment.
remove commented code
Some background on this: Ideally, we want a framework that is easily portable to any platform and any OS. This framework isn't available yet. Many demos under "legacy_apps" are hardcoded to run only on AMD-Xilinx platforms. Eventually they will be deprecated. Hence the name "legacy_apps" makes sense. We don't want to call it "generic" for the same reason, as not all demos are easily portable. Instead, we can introduce new demos under ${REPO}/examples/{OS}/ directory that is portable on all the platforms.
Some demos are using AMD-Xilinx BSP, and so they provide Linux-Baremetal, and Linux-FreeRTOS communication. Some demos provides Linux-Linux communication.
Yes, we should add it, but it can be part of new PR and as enhancement. This PR only moves demos as it is, and makes sure they can be compiled. So, modifying cmake build infra as needed. |
Apps directory was tightly coupled with open_amp library source code. Instead host demo applications in openamp-system-reference repository. This patch copies over source code of apps as it is so build with only this commit is expected to fail. Next commit will introduce changes required to build demos and link open_amp library.
tnmysh
force-pushed
the
move_openamp_demos
branch
from
ca00345 to
3685755
Compare
- Remove version control information - Add cmake infra to find open_amp library - fix open_amp and libmetal library linking Signed-off-by: Tanmay Shah <[email protected]>
Use west to fetch open-amp and libmetal library source code. Signed-off-by: Tanmay Shah <[email protected]>
Add instructions to fetch libraries and build legacy apps and tests. Signed-off-by: Tanmay Shah <[email protected]>
tnmysh
force-pushed
the
move_openamp_demos
branch
from
3685755 to
fe571b8
Compare
|
@iuliana-prodan Thanks for reviews. Fixed comments. |
Move apps directory from open-amp library repo to openamp-system-reference repo and modify cmake build infra structure as needed to build these apps.