Fix safe_strcpy calls #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnmysh
approved these changes
Oct 21, 2024
Fix the size of the source string passed in argument of safe_strcpy(). In rpmsg_create_ept we can not trust the size of the name string provided, so we limit the max size to RPMSG_NAME_SIZE. Update the rpmsg_create_ept documentation to clarify the limit Signed-off-by: Arnaud Pouliquen <[email protected]>
Fix the size of the source string passed in argument of safe_strcpy(). In rpmsg_register_endpoint we can not trust the size of the name string provided, so we limit the max size to RPROC_MAX_NAME_LEN. Signed-off-by: Arnaud Pouliquen <[email protected]>
arnopo
force-pushed
the
fix_safe_strcpy
branch
from
04309e7 to
6b68a74
Compare
|
The |
tnmysh
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #625 reported by @jonny-svaerd-arm
Fix
safe_strcpy()argument that provides the size of the source string. Indeed, if the source string is of type char*, it is not valid to usesizeofto determine its length. Usestrnlento get the size of the string while ensuring that we have a maximum size.On the contrary, it is preferable to use sizeof on
ept->name, that is an array of char