apps: remove remaining master terminology #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glneo
reviewed
May 6, 2024
| @@ -31,7 +31,7 @@ extern struct hil_platform_ops zynq_a9_proc_ops; | |||
| #define SHM_SIZE 0x00200000 | |||
| #define VRING0_IPI_VECT 6 | |||
| #define VRING1_IPI_VECT 3 | |||
| #define MASTER_CPU_ID 0 | |||
| #define MAIN_CPU_ID 0 | |||
There was a problem hiding this comment.
HOST seems to be used more often when paired with REMOTE, such as in RPMSG_HOST.
Is this not used anywhere? If not, better to just drop these two defines.
There was a problem hiding this comment.
the REMOTE_CPU_ID is used, so I have kept it for readability
There was a problem hiding this comment.
Okay, then still would suggest HOST_CPU_ID if these defines need to remain.
|
I also fix few typos in a separate commit |
Some potentially offensive terms are still present in the code. Replace them. Signed-off-by: Arnaud Pouliquen <[email protected]>
arnopo
force-pushed
the
fix-app-term
branch
2 times, most recently
from
deea9cd to
9838bf5
Compare
fix minor typos in platform_info_remoteproc_master.c Signed-off-by: Arnaud Pouliquen <[email protected]>
iuliana-prodan
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some potentially offensive terms are still present in the code, Replace them.