Finish converting rpmsg_virtio to use VIRTIO_ROLE_IS_{DRIVER,DEVICE}() #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `role` member of `struct virtio_device` stores either the value VIRTIO_DEV_DRIVER or VIRTIO_DEV_DEVICE. This means the function rpmsg_virtio_get_role() will also return one of these values. The values RPMSG_HOST and RPMSG_REMOTE are defined to be the same, but there is no need for this redefinition. Update the return values in the comment docs. While here, remove the same from rpmsg_virtio_set_wait_cb() which does not return anything, this looks to be a copy/paste error. Signed-off-by: Andrew Davis <[email protected]>
For all cases when the role is checked in rpmsg_virtio, what is being checked is the role of the underlying virtio layer. As such, we should be matching against the role definitions for the virtio layer (VIRTIO_DEV_DEVICE and VIRTIO_DEV_DRIVER). Fix this here. While the underlying virtio layer may be asymmetric, the RPMSG layer generally is symmetrical. There is no need to define a HOST or REMOTE role specific to the RPMSG layer. And as there are now no more internal users of these definitions, deprecate them here. Signed-off-by: Andrew Davis <[email protected]>
Now that we match role to VIRTIO_DEV_{DRIVER,DEVICE} we can replace
all these double check if statements with the role checking macro
already used in all other files.
Signed-off-by: Andrew Davis <[email protected]>
tnmysh
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up series finishing #560