Use priv data for name-service callback #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rpmsg_virtio_ns_callback() we directly case from rpmsg_device* to rpmsg_virtio_device*. This only works if rdev is the first member. Use metal_container_of() to remove this assumption on struct order. Signed-off-by: Andrew Davis <[email protected]>
There is a private data member in the endpoint struct that is passed into the callback, but there is no way to populate it. Add this to the endpoint register function. Signed-off-by: Andrew Davis <[email protected]>
The callback allows us to add private data. Use that to store our rpmsg_device instance instead of extracting it from the endpoint struct. The contents of that struct are internal to the RPMsg layer. Signed-off-by: Andrew Davis <[email protected]>
arnopo
approved these changes
Mar 22, 2024
xiaoxiang781216
approved these changes
Apr 2, 2024
edmooring
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.