Cleanup rsc_table_parser code and API #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions are only used within rsc_table_parser. These should be only available there and made static. This prevents them from becoming part of the API. Signed-off-by: Andrew Davis <[email protected]>
The files in include/openamp are deployed on install and can be used by applications using the OpenAMP API. The functions in rsc_table_parser are all internal use only. Move this header out of that location. Signed-off-by: Andrew Davis <[email protected]>
Forward declaration of functions here is not needed, simply move the function definition to top of the file. No functional change. Signed-off-by: Andrew Davis <[email protected]>
|
For this one, I am rather in favor. I don't think that this APi is usable by application. |
arnopo
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit messages should provide the details here. Main idea is to not deploy rsc_table_parser.h and inline the handlers.