apps: Add use of rpmsg_virtio_get_tx/rx_buffer_size API #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uLipe
approved these changes
Nov 7, 2023
edmooring
requested changes
Nov 8, 2023
apps/examples/echo/rpmsg-echo.c
Outdated
| @@ -75,6 +75,10 @@ int app(struct rpmsg_device *rdev, void *priv) | |||
| } | |||
|
|
|||
| LPRINTF("Successfully created rpmsg endpoint.\r\n"); | |||
|
|
|||
| LPRINTF("RPMsg device RX buffer size: %#x\r\n", rpmsg_virtio_get_tx_buffer_size(rdev)); | |||
There was a problem hiding this comment.
This line should say "TX buffer size".
There was a problem hiding this comment.
copy past without using my brain... thanks!
|
@arnopo Can we take care of this change once demos are moved to openamp-system-reference? |
Print the max size of the RX and TX buffer payloads. This allows to test the new API in the CI. Signed-off-by: Arnaud Pouliquen <[email protected]>
I'm using these applications for few last integration tests before merging PR. So I would prefer to not wait the move |
tnmysh
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print the max size of the RX and TX buffer payloads. This allows to test the new API implemented in #521 in the CI.