-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpmsg_virtio: add RPMSG_ASSERT to check the virtqueue add error #526
Conversation
29cb3a9
to
f53b47b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment for the code
please also update the commit message.
s/VQUEUE_DEBUG/RPMSG_DEBUG/
f53b47b
to
ea33103
Compare
"When enable the VQUEUE_DEBUG and RPMSG_DEBUG, RPMSG_ASSERT can |
@arnopo I mean we can check the |
Got it, thanks! |
@CV-Bowen, please update the commit message, then ready to merge |
Add RPMSG_ASSERT() to rpmsg_virtio_return_buffer() to check the possible virtqueue buffer add error. Signed-off-by: Bowen Wang <[email protected]>
ea33103
to
023574d
Compare
@arnopo Thanks, Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go.
Add RPMSG_ASSERT() to rpmsg_virtio_return_buffer() to check the possible virtqueue buffer add error.