Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio: make unused function virtio_describe() deprecated #509

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

arnopo
Copy link
Collaborator

@arnopo arnopo commented Oct 9, 2023

The virtio_describe() function does not seem usable. Therefore, it should be marked as deprecated to initiate the removal process.

The virtio_describe() function does not seem usable.
Therefore, it should be marked as deprecated to initiate
the removal process.

Signed-off-by: Arnaud Pouliquen <[email protected]>
@arnopo arnopo requested review from edmooring and tnmysh October 9, 2023 15:48
@arnopo arnopo added this to the Release V2023.10 milestone Oct 13, 2023
@arnopo
Copy link
Collaborator Author

arnopo commented Oct 16, 2023

@edmooring @tnmysh, please add a look, I would like to merge this ne for the coming release

Copy link
Collaborator

@tnmysh tnmysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't have too deep knowledge in virtio space to understand how function should be used however, if function isn't used anywhere for long-time we can deprecate it. And if needed bring-it back later.

@arnopo arnopo merged commit cd88238 into OpenAMP:main Oct 16, 2023
2 checks passed
@arnopo arnopo deleted the deprecate branch May 20, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants