Fixes #151 use coord_cartesian #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `coord_trans()` can't be used for the transformation because the method adding the watermark in background. Consequently, log and discrete transformations still use scale_x/y... - For the same reason, `coord_cartesian()` is used to set the axis limits - suppressMessage is needed for the same reason as scale: multiple coord systems or scales lead to ggplot unwanted messages
ggplot functions for labels and watermark do not use the same size unit. A conversion factor was used to fix that
Codecov Report
@@ Coverage Diff @@
## develop #152 +/- ##
===========================================
+ Coverage 50.78% 50.91% +0.12%
===========================================
Files 54 54
Lines 2408 2414 +6
===========================================
+ Hits 1223 1229 +6
Misses 1185 1185
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coord_trans()can't be used for the transformation because of the method adding the watermark in background. Consequently, log and discrete transformations still usescale_x/y_...()coord_cartesian()is used to set the axis limits