Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "diamond" shape to a later position in the named list #254

Closed
IndrajeetPatil opened this issue May 3, 2022 · 0 comments
Closed

Move "diamond" shape to a later position in the named list #254

IndrajeetPatil opened this issue May 3, 2022 · 0 comments

Comments

@IndrajeetPatil
Copy link
Member

@pchelle As I had pointed out in the meeting, the default size for shape diamond is smaller compared to other shapes.

This wouldn't be an issue, except that in the tlf::Shapes list, it is at the 3rd location. This means that it is pretty much guaranteed to be displayed in most plots.

image

So I was wondering if you would be open to moving this shape to a latter position in this list? I'd argue after "dot". This way, it'd show up only if there are more than 10 groups in DataCombined.

names(tlf::Shapes)
#>  [1] "circle"             "square"             "diamond"           
#>  [4] "triangle"           "triangleDown"       "cross"             
#>  [7] "plus"               "asterisk"           "blank"             
#> [10] "dot"                "hollowCircle"       "hollowSquare"      
#> [13] "hollowDiamond"      "hollowTriangle"     "hollowTriangleDown"
#> [16] "pentagram"          "hollowPentagram"    "cardsDiamond"      
#> [19] "cardsHeart"         "cardsSpade"         "cardsClover"       
#> [22] "cardsHollowDiamond" "cardsHollowHeart"   "cardsHollowSpade"  
#> [25] "cardsHollowClover"  "skull"              "hazard"            
#> [28] "male"               "female"             "sun"               
#> [31] "cloud"              "smiley"             "musicKey"          
#> [34] "hollowFlag"         "arrowLeft"          "arrowRight"        
#> [37] "arrowUp"            "arrowDown"

Created on 2022-05-03 by the reprex package (v2.0.1.9000)

pchelle added a commit to pchelle/TLF-Library that referenced this issue May 4, 2022
@Yuri05 Yuri05 closed this as completed in 9db9115 May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant