Fixes #2356 Update to SimModel 4.0.0.52 causes a PK-Sim test to fail #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a PK-Sim test to fail
Yuri05
commented
Oct 4, 2022
| @@ -3877,7 +3877,7 @@ INSERT INTO tab_calculation_method_rates VALUES('Lumen_PKSim','PARAM_Area','PI*( | |||
| INSERT INTO tab_calculation_method_rates VALUES('Lumen_PKSim','PARAM_DrugAbsorption_para','OralApplicationsEnabled ? P_int_para*Aeff*(EffectiveLumenConcentration-(NOT SinkCondition_para ? fu*DrugMucosa : 0)) : 0','Amount per time'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('Lumen_PKSim','PARAM_DrugAbsorption_trans','OralApplicationsEnabled ? P_int_trans*Aeff*(P_int_trans_lum_cell_factor*EffectiveLumenConcentration-(NOT SinkCondition_trans ? P_int_trans_cell_lum_factor*fu/K_cell_pls*DrugMucosa : 0)) : 0','Amount per time'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('Lumen_PKSim','PARAM_EffectiveSurfaceArea','Ageom*AeffFactor*AeffVariabilityFactor','Area'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('Lumen_PKSim','PARAM_FillLevel','Liquid/V','Dimensionless'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('Lumen_PKSim','PARAM_FillLevel','V>0 ? Liquid/V : 0','Dimensionless'); | |||
There was a problem hiding this comment.
the problem was with the cattle simulation (every simulation, not just pop simulation).
Becasue the cattle GI-tract is not properly implemented yet, all GI parameters are set to zero, resulting in zero volume of all GI compartments.
This resulted in some 0/0 terms of the ODE and thus in NaNs in the RHS.
Before the SimModel fix those terms were apparently not properly evaluated (returning 0 or whatever else).
Adding the check for zero volume here and in the formulas below solves the issue.
There was a problem hiding this comment.
Actually, probably not 0/0 but "Infinity" (as in the example above). Anyways :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test runs again