Fixes #2281 PK-Sim DB: unused tables #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Open-Systems-Pharmacology#2282 PK-Sim DB: unused table in the query Fixes Open-Systems-Pharmacology#2283 PK-Sim DB: missing primary key
Yuri05
commented
Aug 3, 2022
| hidden bigint NOT NULL DEFAULT 0, | ||
| editable bigint NOT NULL DEFAULT 1, | ||
| PRIMARY KEY(table_name, column_name) | ||
| ); |
Yuri05
commented
Aug 3, 2022
| text_value text NOT NULL, | ||
| description text NOT NULL, | ||
| PRIMARY KEY(property) | ||
| ); |
Yuri05
commented
Aug 3, 2022
| [sequence] bigint NOT NULL, | ||
| [transport_type] text, | ||
| PRIMARY KEY([gene], [species], [container_type], [container_name]), | ||
| FOREIGN KEY([container_type], [container_name]) REFERENCES [tab_container_names]([container_type], [container_name]) ON UPDATE CASCADE, |
There was a problem hiding this comment.
Removed duplicated entries and added the primary key
Yuri05
commented
Aug 3, 2022
| [x_min] double NOT NULL, | ||
| [x_max] double NOT NULL, | ||
| [frequency] double NOT NULL, | ||
| PRIMARY KEY([distribution_type], [x_min], [x_max])); |
Yuri05
commented
Aug 3, 2022
| [TAB_REPRESENTATION_INFO].[ICON_NAME] AS [IconName], | ||
| '' AS [SubType] | ||
| FROM [TAB_REPRESENTATION_INFO] | ||
| ORDER BY [TAB_REPRESENTATION_INFO].[DISPLAY_NAME]; |
There was a problem hiding this comment.
removed unused table in the query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2282 PK-Sim DB: unused table in the query
Fixes #2283 PK-Sim DB: missing primary key