Fixes #2175 renaming expression profile #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Apr 6, 2022
| _entity.Name = _newName; | ||
| renameBuildingBlockTask.RenameBuildingBlock(entityAsBuildingBlock, _oldName); | ||
| //Renaming the building block is performed in a special task | ||
| renameBuildingBlockTask.RenameBuildingBlock(entityAsBuildingBlock, _newName); |
There was a problem hiding this comment.
This was weird here. Everything was renamed here. So I am doing it like in the Simulation and moving the logic outside of the comand
| var individual = _simulationSubject.Individual; | ||
|
|
||
| //This needs to be retrieved before performing base operation to ensure that we capture all containers before they are renamed | ||
| var allMoleculeContainers = individual.GetAllChildren<IContainer>(x => x.IsNamed(_oldMoleculeName)); |
There was a problem hiding this comment.
This is removing also the molecule and not the container.
| @@ -42,7 +42,12 @@ public override string Name | |||
| set | |||
| { | |||
| if (string.Equals(Name, value)) | |||
| { | |||
| //Even if the name has not changed, we raise the even here as the underlying composite name may have changed | |||
There was a problem hiding this comment.
This is key to see the Node update on the right. Otherwise, because we have composite names, the name has changed already when the molecule was renamed
Yuri05
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.