2170 some issue with fraciton expressed #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Apr 5, 2022
| private bool isV9Format(SnapshotExpressionProfile snapshot) | ||
| { | ||
| //Localization is only defined for protein and was added in v10 | ||
| return snapshot.Localization == null && snapshot.TransportType == null; |
There was a problem hiding this comment.
This was a wrong condition indeed
| @@ -186,6 +186,13 @@ private void addExpressionProfilesUsedBySimulationSubjectToProject(ISimulationSu | |||
| expressionProfile.Category = simulationSubject.Name; | |||
| _expressionProfileUpdater.SynchronizeExpressionProfileWithSimulationSubject(expressionProfile, simulationSubject); | |||
|
|
|||
| //Some parameters are probably marked as FixedValue event thought they have not changed (Formula=>constant) due to change in | |||
| //definition of Fraction expressed basolateral going from a constant to a formula. We reset | |||
| expressionProfile.Individual.AllMoleculeParametersFor(expressionProfile.Molecule) | |||
There was a problem hiding this comment.
This is gbecause we explictely overwrite formula with constant in this very specific case (the comment says for Permeability formula)...
| protected override void TypedDeserialize(TPopulation population, XElement element, SerializationContext serializationContext) | ||
| { | ||
| //Lazy loading a population may results in expression profiles references being wiped out. We save them before setting them back again | ||
| var allExpressionProfiles = population.AllExpressionProfiles().ToArray(); |
There was a problem hiding this comment.
Interesting. They are defined before we lazy load. Then we load from XML and they disappear (because ref are not saved in XML). therefor, some trickery here
Yuri05
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.