Fixes #2140 fraction basolateral not set properly #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Mar 28, 2022
| @@ -73,6 +73,10 @@ private void updateFractionExpressedEpithelial(TransporterExpressionContainer tr | |||
| if (fractionExpressedApical == null) | |||
| return; | |||
|
|
|||
| //Parameter is a hidden parameter. This is used for consistency purpose only and should not be updated | |||
| if (!fractionExpressedApical.Visible) | |||
There was a problem hiding this comment.
A bit to eager here. The null above was covering exactly this. But now that we have this parameter everywhere, we should only update if we can actually set it
There was a problem hiding this comment.
lol
always those nice side effects 😄
Yuri05
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.