Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return null if subject not implementing IWithId #2094

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PKSim.Presentation/Services/WorkspaceLayoutUpdater.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private WorkspaceLayout createNewWorkspaceLayoutWithOpenPresenters()
var workspaceLayout = new WorkspaceLayout();
foreach (var presenter in _applicationController.OpenedPresenters())
{
var withId = presenter.Subject.DowncastTo<IWithId>();
var withId = presenter.Subject as IWithId;
if (withId == null) continue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for this

var workspaceLayoutItem = new WorkspaceLayoutItem {WasOpenOnSave = true, SubjectId = withId.Id, PresentationSettings = presenter.GetSettings()};
workspaceLayout.AddLayoutItem(workspaceLayoutItem);
Expand Down