2055 old values not scaled #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Feb 9, 2022
| ExpressionValue, | ||
| RelativeExpressionNew, | ||
| Unit | ||
| public static string Container = "Container"; |
There was a problem hiding this comment.
I created those so that we could remove the .ToString() used EVERYWHERE!!
msevestre
commented
Feb 9, 2022
| }; | ||
| } | ||
|
|
||
| private int getPercentageMax(DataView dataView, string columnName) |
There was a problem hiding this comment.
This is the change. Instead of setting the max to 100, I set the max to the max value in the column (int) and then this will be used as max for the repo. The scaling is then done automatically
|
@Yuri05 This cannot be tested, unfortunately. Everything happens in the view. |
|
and this? |
Yuri05
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel that I am patching a leak with some tap but it's better than nothing..