Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating pk-sim #2079

Merged
merged 9 commits into from
Feb 3, 2022
Merged

updating pk-sim #2079

merged 9 commits into from
Feb 3, 2022

Conversation

georgeDaskalakis
Copy link
Contributor

No description provided.

@georgeDaskalakis georgeDaskalakis self-assigned this Jan 31, 2022
@georgeDaskalakis georgeDaskalakis linked an issue Jan 31, 2022 that may be closed by this pull request
PK-Sim not up to date with latest importer changes #2078
Closed
@georgeDaskalakis georgeDaskalakis marked this pull request as draft January 31, 2022 11:17
@msevestre
Copy link
Member

:\projects\pk-sim-g4na9\src\PKSim.Infrastructure\Services\ImportObservedDataTask.cs(29,67): error CS0535: 'ImportObservedDataTask' does not implement interface member 'IObservedDataConfiguration.MolWeightEditable' [C:\projects\pk-sim-g4na9\src\PKSim.Infra

still failing

@georgeDaskalakis
Copy link
Contributor Author

:\projects\pk-sim-g4na9\src\PKSim.Infrastructure\Services\ImportObservedDataTask.cs(29,67): error CS0535: 'ImportObservedDataTask' does not implement interface member 'IObservedDataConfiguration.MolWeightEditable' [C:\projects\pk-sim-g4na9\src\PKSim.Infra

still failing

I know that's why I converted to a draft..weird though cause the rename of this interface member is part of the PR... i ll look into this a bit more

@msevestre
Copy link
Member

oh sorry did not see. I got a notification that my review was required.

@georgeDaskalakis georgeDaskalakis marked this pull request as ready for review February 2, 2022 12:06
@georgeDaskalakis
Copy link
Contributor Author

@msevestre after fixing the duplicate packages thing, this is ready for reveiew :)

@msevestre msevestre merged commit 08f512e into develop Feb 3, 2022
@msevestre msevestre deleted the 2078-updating-pk-sim branch February 3, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msevestre msevestre msevestre left review comments

Assignees

@georgeDaskalakis georgeDaskalakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PK-Sim not up to date with latest importer changes
2 participants
@georgeDaskalakis @msevestre