-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Y2 in plots of Qualification Report (Workflow.R) #934
Comments
I guess you are talkimg about this plot: https://raw.githubusercontent.com/Open-Systems-Pharmacology/OSP-PBPK-Model-Library/master/Fluconazole/images/003_3_Results_and_Discussion/003_3_3_Concentration-Time_Profiles/001_3_3_1_Model_Building/003_plotTimeProfile.png (here created in Matlab.) |
This is my plot, both observations and model prediction on Y2 axis are missing. it seems that my issue is not specific only for the fluconazole report but for a simple template when I add a second plot on Y2, I cannot get it in the generated pictures from the reporting engine. |
This is a limitation of the current versions of |
Thanks Pierre for your answer. May I ask if this is a limitation only for R users (worflow.R)? because in the original qualification report which was generated using Matlab (workflow.m) Y2 exists. https://github.com/Open-Systems-Pharmacology/OSP-PBPK-Model-Library/tree/master/Fluconazole One option as you said is separating the plots, but Do you think using Matlab instead of R is also an option to solve this issue? |
Yes, it is currently a limitation for R users only. |
thanks a lot Pierre, may I ask:
|
@Yuri05 , please correct me if I am wrong
Yes, we intend to add the Y2 axis feature for time profile plots. However, I don't know in terms of timeline exactly when we will fix that.
You will find the instructions for using the Matlab qualification framework here |
Hello Pierre, thanks for your supports. For the moment, I switch to MATLAB. thanks for your supports. |
@GhazalMontaseri Matlab Reporting Engine is just zipped Matlab source code . |
thank you so much Juri, I used ''addpath'' command to add all subfolders to the search path. |
@Yuri05 Hello Yuri, may I ask if in the new release, adding the Y2 axis feature for time profile plots in the qualification report workflow.R, has been resolved? |
Hello @GhazalMontaseri , this will be fixed in the next release, which will be hopefully available till the end of March. |
…al axis in time profiles Also Fixes Open-Systems-Pharmacology#985 The fix requires PR [407](Open-Systems-Pharmacology/TLF-Library#407) from tlf package and might have side effects on the legend order of other plots performed by the reporting engine
Dear @GhazalMontaseri , new release with the fixed Y2-issue is available now: |
Thanks @Yuri05 . |
Hello @Yuri05, can you please help me how I may modify/increase size of points in the generated Gof plots from the qualification report? As you see below the points are very small. |
Hi @GhazalMontaseri ,
If the symbol size is still too small, you can modify the downloaded theme file and increase it, e.g. |
You can also modify the theme properties programmatically, s. E.g.
|
Please note, that those changes are global and will apply to all workflows which are executed after the setting of the new theme. |
Hello @Yuri05 , I tried this in my workflow.R: jsonFile <- system.file("extdata", "re-theme.json", package = "ospsuite.reportingengine") reTheme$plotConfigurations$plotObsVsPred$points$size=8 --> for GoF plots setDefaultTheme(reTheme) However, while point size in the GoF plot has been increased this is not the case for the time profile plot (second Y-axis has some points but very small) |
It's a bug :( You can try the latest development version of the reporting engine where this bug was fixed.
Then install the latest development version of the OSP packages:
|
Thanks @Yuri05 , any plan to release the validated reporting engine package with this bug being fixed in near future? |
Hopefully till the end of summer |
I tried to generate the qualification report for Fluconazole model based on files provided here:
https://github.com/Open-Systems-Pharmacology/Fluconazole-Model
However, instead of Workflow.m I have used workflow.R as described here:
https://www.open-systems-pharmacology.org/OSPSuite.ReportingEngine/articles/qualification-workflow.html#template
I have PK-Sim portable version 11 and latest version of 'QualificationRunner'. The issue is in concentration-time profiles with double Y axes like Y and Y2 (like the third plot in section 3.3.1), I got a plot with only Y and not both Y and Y2. Can you please help me with this issue?
The text was updated successfully, but these errors were encountered: