Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEanModel/Pop Workflow: Introduce dataSelection on the SimulationSet level #881

Closed
Yuri05 opened this issue Jul 7, 2022 · 1 comment
Closed

Comments

@Yuri05
Copy link
Member

Yuri05 commented Jul 7, 2022

This is already the case in the excel template: we have dataSelection on the Output level and on the SimulationSet level.
When generating the code from excel, those 2 dataSelections are concatenated and set as dataSelection of the Output.

Because of this, Outputs are duplicated in the generated code (SimulationSet1.Output1, SimulationSet2.Output2, etc.)

With this change, it will be possible to reduce the complexity of the generated R-Code (each Output is exported only once).
It will be also possible to assign some properties to an Output (e.g. colours) which will be used in ALL plots for this output.

@pchelle
Copy link
Collaborator

pchelle commented Oct 20, 2022

@Yuri05
What should be the default selection for the simulation set level ? Select all the data in the dataset or select none of the data in the dataset ?
Currently, default selection for output was none of the data was selected

pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Oct 25, 2022
pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Oct 25, 2022
…t level

Deprecate evalDataFilter in favor of functions relying on dplyr::filter
@Yuri05 Yuri05 closed this as completed in 54e6dc3 Oct 26, 2022
@Yuri05 Yuri05 moved this to Fixed in Version 2.1 / 2.2 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Fixed
Development

No branches or pull requests

2 participants