Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new github artifacts ? #1258

Closed
pchelle opened this issue Jul 25, 2024 · 2 comments
Closed

Migrate to new github artifacts ? #1258

pchelle opened this issue Jul 25, 2024 · 2 comments

Comments

@pchelle
Copy link
Collaborator

pchelle commented Jul 25, 2024

@Yuri05
The current build is failing, does this mean we have to use the new github artifacts for {rSharp} and {ospsuite} ?

@pchelle
Copy link
Collaborator Author

pchelle commented Jul 29, 2024

Following up on comment from PR #1246

rsharp branch was merged and probably deleted. Please use this for now: ospsuite-v12.1.0-Windows-r_4.4.1 (unzip first like rSharp)

I am trying to figure out how to get the run-inependent permalink

I also tried and the main issue is that each artifact is linked to the run ID.
Would it be relevant to create an "archives" repo where we would store all the R zip bundles for {ospsuite.utils}, {rSharp}, {rClr}, {ospsuite} and {ospsuite.reportingengine} split with release and develop sub-repos (with one sub repo for each release) ?
After a build worklfow from a R package has run correctly, it could dump the zip bundle in that archives repo.
@Yuri05 , thoughts ?

@Yuri05
Copy link
Member

Yuri05 commented Jul 29, 2024

no, we shouldn't do this.
If there is no possibility to get a run-independent permalink for the artifact: we could install e.g. via
remotes::install_github("Open-Systems-Pharmacology/OSPSuite-R")

pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Jul 29, 2024
@Yuri05 Yuri05 closed this as completed in e7f1950 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants