Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the time point of the offset should be included in the list of the output time points #1237

Closed
Yuri05 opened this issue Jun 24, 2024 · 1 comment

Comments

@Yuri05
Copy link
Member

Yuri05 commented Jun 24, 2024

          Another question: is it guaranteed that the time point of the offset is included in the list of the output time points?

E.g. if my initial output raster is 0h, 1h, 2h, ... and my time offset is 30 min: will 30min be included in the output time points?

Originally posted by @Yuri05 in #1232 (comment)

@Yuri05 Yuri05 changed the title Another question: is it guaranteed that the time point of the offset is included in the list of the output time points? Check if the time point of the offset should be included in the list of the output time points Jun 24, 2024
@pchelle
Copy link
Collaborator

pchelle commented Jun 28, 2024

@pchelle Btw, it is indeed possible to add single time points to the simulation output schema via https://www.open-systems-pharmacology.org/OSPSuite-R/dev/reference/OutputSchema.html#method-addtimepoints- However it's not quite clear for me, if the added values are automatically assumed as the internal time unit ([min]) or units can be passed additionally (just created issues for this in ospsuite-r)

Tried it on a simulation, timePoints are using base unit

pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Jun 28, 2024
@Yuri05 Yuri05 closed this as completed in 66aee3f Jul 5, 2024
@Yuri05 Yuri05 moved this to Fixed in Version 2.1 / 2.2 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Fixed
Development

No branches or pull requests

2 participants