- Corrected usage of grepl in an if-statement in validateIsOfType
#123
Conversation
| @@ -81,7 +81,7 @@ validateIsOfType <- function(object, type, nullAllowed = FALSE) { | |||
| callStack <- as.character(sys.call(-1)[[1]]) | |||
|
|
|||
| # Object name is one frame further for functions such as ValidateIsNumeric | |||
| if ((length(callStack) > 0) && grepl(pattern = "validateIs", x = callStack)) { | |||
| if ((length(callStack) > 0) && any(grepl(pattern = "validateIs", x = callStack))) { | |||
There was a problem hiding this comment.
grepl returns a list of booleans if callStack is larger than 1, but we need a single boolean here.
Codecov ReportBase: 99.50% // Head: 99.50% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #123 +/- ##
========================================
Coverage 99.50% 99.50%
========================================
Files 18 18
Lines 202 202
========================================
Hits 201 201
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@Yuri05
|
I would suggest to remove all |
|
I restarted the test coverage and it worked - was just a temporary glitch for sure. |
|
@Yuri05 removed checks for Ubuntu job fails with
No idea why. |
@PavelBal Restarted the job with success. Again, seems to be a temporary problem of GitHub(?) |
This was causing test fails when locally performing "check" for ospsuite-r.