Fixes #1925 #1926
Merged
Fixes #1925 #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Mar 18, 2023
| @@ -31,20 +31,14 @@ private static SvgImage bytesToImage(byte[] bytes) | |||
|
|
|||
| public static implicit operator SvgImage(ApplicationIcon icon) => icon.ToSvgImage(); | |||
|
|
|||
| public static implicit operator Image(ApplicationIcon icon) => icon.ToImage(); | |||
There was a problem hiding this comment.
@Yuri05 When we moved to svg, we lost the ability to convert implicitly to image. This was a breaking change that I did nto realize. The component that display in the grid only accepts image and hence the bug. Thsi is also a bug in a few other places in PKSim where we are returning an icon instead of an image (pop import from csv file for instance). Hence I decided to fix it here instead of everywhere
msevestre
deleted the
1925-applicationicon-should-convert-implicitely-to-image
branch
rwmcintosh
added a commit
that referenced
this pull request
Feb 14, 2024
* 1886 importer unit for fraction not recognized (#1892) * changing the check * correction to get the first non empty unit * cleaning up * Fixes #1925 (#1926) @Yuri05 Merging. NEed to test in the app * Fixes #1925 (#1927) * 2566 fixed (#1932) * nunit adapter updated (#1938) * Fixes #1379 (#1948) * Fixes #1946 mobi cannot handler observed data sets with only 1 point (#1947) * Fixes #1949 data importer parsing unit should be case insensitive (#1952) * Fixes #1949 data importer parsing unit should be case insensitive * Run resharper * Remove fake to use real dimensions * Remove fake to use real dimensions * refactoring and removing further .HasUnit() calls --------- Co-authored-by: georgeDaskalakis <[email protected]> * preventing exception (#1957) * templates changed (#1962) --------- Co-authored-by: georgeDaskalakis <[email protected]> Co-authored-by: Michael Sevestre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.