1872 importer metaData messed up fixed

[georgeDaskalakis]

@msevestre @Yuri05 @rwmcintosh this error comes from the fact that when we are setting the mappings for the DataSource, we first set the mapping parameters and then add the grouping ones:

OSPSuite.Core/src/OSPSuite.Presentation/Presenters/Importer/ImporterPresenter.cs

Lines 212 to 239 in 2529fd7

	private void loadSheets(IDataSourceFile dataSourceFile, IReadOnlyList<string> sheetNames, string filter, string selectedNamingConvention = null)
	{
	if (!sheetNames.Any())
	{
	View.DisableConfirmationView();
	return;
	}
	var sheets = dataSourceFile.DataSheets.GetDataSheetsByName(sheetNames);
	var dataMappings = dataSourceFile.Format.Parameters.OfType<MetaDataFormatParameter>().Where(p => p.ColumnName != null).Select(md =>
	new MetaDataMappingConverter()
	{
	Id = md.MetaDataId,
	Index = sheetName => md.IsColumn ? dataSourceFile.DataSheets.GetDataSheetByName(sheetName).GetColumnDescription(md.ColumnName).Index : -1
	}).ToList();
	var mappings = dataMappings.Union
	(
	dataSourceFile.Format.Parameters.OfType<GroupByDataFormatParameter>().Select(md => new MetaDataMappingConverter()
	{
	//in case of a duplicate name coming from an excel column used as a grouping by with the same name as a metaData, we add a suffix
	Id = dataMappings.ExistsById(md.ColumnName) ? md.ColumnName + Constants.ImporterConstants.GroupingBySuffix : md.ColumnName,
	Index = sheetName => dataSourceFile.DataSheets.GetDataSheetByName(sheetName).GetColumnDescription(md.ColumnName).Index
	})
	).ToList();
	_dataSource.SetMappings(dataSourceFile.Path, mappings);

whereas when creating the ParsedDataSet we would just get all the parameters in a row. That means that when the user would set the grouping and afterwards set a mapping parameter, all the mappings set after the grouping would get assigned wrong values.

[Yuri05]

2merge | ¬ 2merge ?

[rwmcintosh]

2merge | ¬ 2merge ?

My comment is only a suggestion to improve the readability for @georgeDaskalakis.

[georgeDaskalakis]

@Yuri05 I have implemented Rob's suggestion - since @msevestre has not had any comments I think we can merge yes