Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1807 wrong icon fixed #1808

Merged
merged 1 commit into from
Nov 22, 2022
Merged

1807 wrong icon fixed #1808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OSPSuite.Presentation/Presenters/SimulationResidualVsTimeChartPresenter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class SimulationResidualVsTimeChartPresenter : SimulationVsObservedDataCh
public SimulationResidualVsTimeChartPresenter(ISimulationVsObservedDataView view, ChartPresenterContext chartPresenterContext,
IObservedDataRepository observedDataRepository, IResidualCalculatorFactory residualCalculatorFactory,
IResidualsVsTimeChartService residualsVsTimeChartService)
: base(view, chartPresenterContext, ApplicationIcons.PredictedVsObservedAnalysis,
: base(view, chartPresenterContext, ApplicationIcons.ResidualVsTimeAnalysis,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgeDaskalakis in MoBi, another presenter is used?
(just wondering because the icon in MoBi was displayed correctly before the fix)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuri05, yes in MoBi we have the fixed tabs, taht are explicitely named in code. The caption is the same one of course, coming from Core.

PresenterConstants.PresenterKeys.SimulationPredictedVsObservedChartPresenter)
{
_observedDataRepository = observedDataRepository;
Expand Down