587 get seed #607
Merged
587 get seed #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Sep 8, 2021
| @@ -90,8 +90,6 @@ Collate: | |||
| 'table-formula.R' | |||
| 'user-defined-pk-parameter.R' | |||
| 'utilities-container.R' | |||
| 'utilities-data-import-configuration.R' | |||
| 'utilities-data-importer-configuration.R' | |||
There was a problem hiding this comment.
@PavelBal I am not sure what these files were about? They were empty or containing an empty function
| population <- Population$new(netPopulation) | ||
|
|
||
| individualCharacteristics <- NULL | ||
|
|
||
| # NOTE THIS IS A WORKAROUND UNTIL THE CODE IN PKSIM IS UPDATED |
There was a problem hiding this comment.
Also fixed this in PKSim
| if (len == 0) { | ||
| rep(NA, length(dataSet$xValues)) | ||
| } else if (len == 1) { | ||
| columForDataSet <- function(dataSet) { |
There was a problem hiding this comment.
just running styler here
| @@ -1,6 +1,8 @@ | |||
| context("New DataImporterConfiguration") | |||
|
|
|||
| test_that("it can create a new data importer configuration", { | |||
| skip_on_os("linux") # TODO enable again as soon as npoi works under linux | |||
There was a problem hiding this comment.
this was missing everywhere too
| @@ -1,6 +1,8 @@ | |||
| context("New DataImporterConfiguration") | |||
|
|
|||
| test_that("it can create a new data importer configuration", { | |||
| skip_on_os("linux") # TODO enable again as soon as npoi works under linux | |||
|
|
|||
| importerConfiguration <- DataImporterConfiguration$new() | |||
There was a problem hiding this comment.
I honestly do not like the fact that so much happens on new. A constructor should be very fast and NEVER crash.
I would like to see a method on that object for importing or creating. Right now this is all implicit and it is not what I would expect
PavelBal
approved these changes
Sep 9, 2021
|
Ah ok, the dlls must be updated for the build to success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.