Add getAllStateVariablesPaths #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #526 +/- ##
===========================================
+ Coverage 88.52% 88.56% +0.03%
===========================================
Files 72 72
Lines 1438 1443 +5
===========================================
+ Hits 1273 1278 +5
Misses 165 165
Continue to review full report at Codecov.
|
msevestre
requested changes
May 25, 2021
R/utilities-simulation.R
Outdated
| #' @return A list of paths | ||
| #' @export | ||
| getAllStateVariablesPaths <- function(simulation) { | ||
| validateIsOfType(simulation, type = "Simulation") |
There was a problem hiding this comment.
you can pass a ref to the R6 class directly here (e..g validateIsOfType(simulation, Simulation) which removes the use of "magic" string
R/utilities-simulation.R
Outdated
| #' @export | ||
| getAllStateVariablesPaths <- function(simulation) { | ||
| validateIsOfType(simulation, type = "Simulation") | ||
| allMoleculesPaths <- getAllEntityPathsIn(container = simulation, entityType = Molecule) |
There was a problem hiding this comment.
getAllMoleculePathsIn instead. Since we have a convenience method for this, why not use it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.