Parallel run #511
Merged
Parallel run #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests require the latest Core. |
msevestre
reviewed
Apr 27, 2021
| simulationResults[[id]] <- SimulationResults$new(ref = rClr::clrGet(resultObject, "Result"), simulation = simulationsIdMap[[id]]) | ||
| next() | ||
| } | ||
| # If the simulation run failed, show a warning |
There was a problem hiding this comment.
Should not we set simulationResults[[id]] to NULL or sthg here ? to show that something is off?
There was a problem hiding this comment.
All values are NULL after initialization of simulationResults and are overwritten if the result exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of running simulations concurrently.
Concurrent batch simulations will follow in a separate PR.
FYI @abdelr