Fixes #493 units for dimensions #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Mar 25, 2021
| #' This is purely for optimization purposes | ||
| #' | ||
| #' @return An instance of the Task | ||
| getDimensionTask <- function() { |
There was a problem hiding this comment.
@PavelBal I added your method here. I'd love to know how much of a difference such as small optimization is making
There was a problem hiding this comment.
To be honest I did not investigate it. Might think of a use case and profile it.
There was a problem hiding this comment.
Yeah. I am pretty sure this is completely insignificant to be honest. But well why not
msevestre
commented
Mar 25, 2021
| @@ -65,6 +65,7 @@ export(getParameterDisplayPaths) | |||
| export(getQuantity) | |||
| export(getSimulationTree) | |||
| export(getStandardMoleculeParameters) | |||
| export(getUnitsForDimension) | |||
There was a problem hiding this comment.
@abdullahhamadeh This will be soon available in ospsuite-r Returns all units for a given dimension name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.