Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

475 reactivate linux build #477

Merged
merged 6 commits into from
Mar 2, 2021
Merged

475 reactivate linux build #477

merged 6 commits into from
Mar 2, 2021

Conversation

msevestre
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #477 (96477be) into develop (ecb2bb4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #477   +/-   ##
========================================
  Coverage    88.15%   88.15%           
========================================
  Files           68       68           
  Lines         1216     1216           
========================================
  Hits          1072     1072           
  Misses         144      144           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb2bb4...bd1c5c9. Read the comment docs.

$ErrorActionPreference = "Stop"
Invoke-WebRequest http://raw.github.com/krlmlr/r-appveyor/master/scripts/appveyor-tool.ps1 -OutFile "..\appveyor-tool.ps1"
Import-Module '..\appveyor-tool.ps1'
- ps: Update-AppveyorBuild -Version "$($env:ospsuite_version).$($env:appveyor_build_version)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuri05 Unrelated but ensure that we are using the global version (suite component)

copy_files_to_lib_folder

update_package_version(product_version)

install_pksim('feature/relative_expression_redesign')
install_pksim('develop')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuri05 Done

@@ -168,9 +168,9 @@ def sanitized_version(version)
def update_package_version(version)
#Replace token Version: x.y.z with the version from appveyor
replacement = {
/Version: \d\.\d\.\d/ => "Version: #{version}"
/Version: \d+\.\d+\.\d+/ => "Version: #{version}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reged. .was parsing 9.x.z but not 10.x.z...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@msevestre msevestre requested a review from Yuri05 March 2, 2021 17:57
@msevestre msevestre merged commit 6bdc76d into develop Mar 2, 2021
@msevestre msevestre deleted the 475-reactivate-linux-build branch March 2, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants