Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update core #1379

Merged
merged 4 commits into from
Mar 26, 2024
Merged

update core #1379

merged 4 commits into from
Mar 26, 2024

Conversation

rwmcintosh
Copy link
Member

No description provided.

@rwmcintosh rwmcintosh requested a review from Yuri05 March 25, 2024 10:45
@rwmcintosh
Copy link
Member Author

Pavel is going to update the snapshots and get this to pass CI checks before we merge this branch

@Felixmil Felixmil self-requested a review March 26, 2024 09:47
Copy link
Contributor

@Felixmil Felixmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hotfix/11.3 contains very old code that is unsynced with develop.

  1. Is hotfix/11.3 really the target branch ?
  2. If so, shouldn't hotfix/11.3 be updated with develop content ?

@Yuri05
Copy link
Member

Yuri05 commented Mar 26, 2024

This hotfix/11.3 contains very old code that is unsynced with develop.

1. Is hotfix/11.3 really the target branch ?

2. If so, shouldn't hotfix/11.3 be updated with `develop` content ?

1: yes
2: no

The version is synced with the upcoming 11.3 hotfix release of the OSP suite and should not get any newer v12 features from the develop branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add fixed package versions corresponding to the AppVeyor's installation script for this release.
Necessary because some breaking changes were included in tlf without backward compatibility.

@rwmcintosh rwmcintosh merged commit 5292f64 into hotfix/11.3 Mar 26, 2024
1 check passed
@rwmcintosh rwmcintosh deleted the update_core_272 branch March 26, 2024 12:13
@Yuri05
Copy link
Member

Yuri05 commented Mar 26, 2024

@rwmcintosh I retriggered manualy the nightly build and it failed

rake "prepare_for_build[%APPVEYOR_BUILD_VERSION%, 'hotfix/11.3']"
OpenURI::HTTPError: 404 Not Found
...
Downloading setup.zip from https://ci.appveyor.com/api/projects/open-systems-pharmacology-ci/pk-sim/artifacts/setup.zip?branch='hotfix/11.3' under C:/temp/pk-sim/setup.zip

Do we really need '' in 'hotfix/11.3' ?
Let's remove '' in 'hotfix/11.3'

@rwmcintosh
Copy link
Member Author

yeah, maybe not. I'll change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants