-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plotObservedVsSimulated(): error when DataCombined only contains observed or simulated results #1012
Comments
Same for observed only |
In both cases, the function will return a library(ospsuite)
dataSet1 <- DataSet$new(name = "Dataset1")
dataSet1$setValues(1, 1)
dataSet1$yDimension <- ospDimensions$`Concentration (molar)`
dataSet1$molWeight <- 1
myCombDat <- DataCombined$new()
plotObservedVsSimulated(myCombDat)
#> Warning in plotObservedVsSimulated(myCombDat): No plot can be created because
#> the entered `DataCombined` object does not contain any datasets.
#> NULL
myCombDat$addDataSets(dataSet1)
plotObservedVsSimulated(myCombDat)
#> Following datasets were specified to be grouped but not found:
#> Dataset1
#>
#> Warning in plotObservedVsSimulated(myCombDat): No plot can be created because
#> the entered `DataCombined` object does not contain any observed-simulated
#> datasets that can be paired.
#> NULL Created on 2022-07-04 by the reprex package (v2.0.1.9000) |
IndrajeetPatil
added a commit
that referenced
this issue
Jul 4, 2022
6 tasks
IndrajeetPatil
added a commit
that referenced
this issue
Jul 18, 2022
* initialize `plotObservedVsSimulated()` * naming * preliminary test * show message only once across groups * interpolation in edge case * DRY in setting same properties across plots * also test custom plot * for now, only one line * also test smoother * update snapshots * fix tests * fix tests * Use `foldDistance` arg from tlf * Need the latest version * fix documentation issue This issue was introduced in #995 * introduce tolerance * Use unit-dependent thresholds * linear smoother by default * add example to aggregated data function * Update DefaultPlotConfiguration.Rd * correct fold distance * deal with linear scale * update snapshot * set smoother to NULL * use long dash * use expand * add expand option * better * use messages instead * minor * catch with tlf * update snapshots * pass args to legend config * update other plots as well * legend key text should be left-aligned * address code review comments * test adding more fold distances work * Return `NULL` when `DataCombined` is empty Closes #1010 Closes #1011 * Handle edge case in paired plot Closes #1012 * remove `smoother` arg * update snapshots * fix legend alignment issue * legendCaption -> legendKeys * catch up with tlf * also include residual values * add error bars to the plot * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Instead, it should produce an empty plot (and, if defined in the plot configuration, title subtitle and so on).
The text was updated successfully, but these errors were encountered: