error bars for observed data in population profile

Closes #1059
Open-Systems-Pharmacology · Aug 2, 2022 · a6f6df7 · a6f6df7
1 parent 75d8ee3
commit a6f6df7
Show file tree

Hide file tree

Showing 5 changed files with 248 additions and 12 deletions.
diff --git a/R/plot-individual-time-profile.R b/R/plot-individual-time-profile.R
@@ -67,6 +67,7 @@ plotIndividualTimeProfile <- function(dataCombined,
     hasMultipleObsDatasetsPerGroup <- FALSE
   } else {
     hasMultipleObsDatasetsPerGroup <- .hasMultipleDatasetsPerGroup(obsData)
+    obsData <- .computeBoundsFromErrorType(obsData)
   }
 
   simData <- as.data.frame(dplyr::filter(combinedData, dataType == "simulated"))
@@ -116,6 +117,8 @@ plotIndividualTimeProfile <- function(dataCombined,
       observedDataMapping <- tlf::ObservedDataMapping$new(
         x = "xValues",
         y = "yValues",
+        ymin = "yValuesLower",
+        ymax = "yValuesHigher",
         group = "group"
       )
     }
@@ -124,8 +127,6 @@ plotIndividualTimeProfile <- function(dataCombined,
   # individual time profile mappings ------------------------------
 
   if (is.null(quantiles)) {
-    obsData <- .computeBoundsFromErrorType(obsData)
-
     if (hasMultipleSimDatasetsPerGroup) {
       simulatedDataMapping <- tlf::TimeProfileDataMapping$new(
         x = "xValues",

diff --git a/tests/testthat/_snaps/plot-population-time-profile/both-observed-and-simulated.svg b/tests/testthat/_snaps/plot-population-time-profile/both-observed-and-simulated.svg