Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI changes in Qt for SSO #1813

Merged
merged 10 commits into from
Jul 21, 2023
Merged

UI changes in Qt for SSO #1813

merged 10 commits into from
Jul 21, 2023

Conversation

nilupulmanodya
Copy link
Collaborator

@nilupulmanodya nilupulmanodya commented Jul 5, 2023 •
edited
Loading

  • Disable Add user btn
  • Add section for login with IDP

image

@ReimarBauer
Copy link
Member

ReimarBauer commented Jul 6, 2023 •
edited
Loading

A better solution is to hide the section, e.g. show only the section needed not both at a time.

ui

When an admin only enables IDP Login, the other path is completly unknown to users, we should hide that completly

The login button label also could be changed to Login by Identity Provider so it won't need the extra label.

You could add a placeholder widget and add the button programatically with its connection.

@nilupulmanodya
Copy link
Collaborator Author

A better solution is to hide the section, e.g. show only the section needed not both at a time.

ui

When an admin only enables IDP Login, the other path is completly unknown to users, we should hide that completly

The login button label also could be changed to Login by Identity Provider so it won't need the extra label.

You could add a placeholder widget and add the button programatically with its connection.

Updated :

  • Allowed admin to enable or disbale IDP login

  • if IDP_ENABLED = False UI looks like,

image

  • if IDP_ENABLED = True UI looks like,

image

matrss
matrss reviewed Jul 11, 2023
View reviewed changes
mslib/msui/mscolab.py Outdated Show resolved Hide resolved
matrss
matrss reviewed Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@matrss matrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, otherwise this looks good to me.

Something to keep in mind: with the changes to the /status endpoint, it looks like older msui versions cannot connect to a newer mscolab server, i.e. the msui version from stable fails to connect. Not sure if this is an issue for us, users should regularly update anyway.

mslib/msui/mscolab.py Outdated Show resolved Hide resolved
mslib/msui/ui/ui_mscolab_connect_dialog.ui Outdated Show resolved Hide resolved
@nilupulmanodya nilupulmanodya mentioned this pull request Jul 17, 2023
Merged
matrss
matrss approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@matrss matrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReimarBauer
Copy link
Member

please add the new config option also to the sample config
https://github.com/Open-MSS/MSS/blob/GSOC2023-NilupulManodya/docs/samples/config/mscolab/mscolab_settings.py.sample

later it needs to become described too.

ReimarBauer
ReimarBauer requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

mslib/msui/mscolab.py Outdated Show resolved Hide resolved
mslib/msui/mscolab.py Outdated Show resolved Hide resolved
tests/_test_mscolab/test_server.py Show resolved Hide resolved
ReimarBauer
ReimarBauer approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work thx :)

@ReimarBauer ReimarBauer merged commit 106bee5 into Open-MSS:GSOC2023-NilupulManodya Jul 21, 2023
ReimarBauer added a commit that referenced this pull request Nov 7, 2023
@ReimarBauer @nilupulmanodya @matrss
merge of Gsoc2023 nilupul manodya (#2069)
f6b3ad1 
* remove inputs from conditions (#1808)

* Setup sp and idp for the sso (#1809)

* configure sp and idp

* update meta.yml remove cherypy

* fixes previous

* update notice

* update readme

* regroup idp_uwsgi

* regroup app.py

* regroup, change wsgi server to flask

* Update conf_sp_idp/README.md

Co-authored-by: Matthias Riße <[email protected]>

* hide secrets by config

* update copy-paste-able command for creating keys and certificates

* Update README.md

* correct copyright lines

* remove make_metadata.py file and update doc with new flow

* remove idp.xml file

* remove condition libxmlsec1

* Update conf_sp_idp/sp/app/conf.py

Co-authored-by: Matthias Riße <[email protected]>

* Update conf_sp_idp/idp/idp.py

Co-authored-by: Matthias Riße <[email protected]>

* remove generate_metadatascript

* remove hardcoded path

* recorrect copyrights

---------

Co-authored-by: Matthias Riße <[email protected]>

* Split conf sp idp (#1811)

* split sp and idp

* generate doc

* remove prints idp.py

* update comeponents.rst

* UI changes in Qt for SSO (#1813)

* ui changes in qt for sso

* fixes qt UI implementation

* get idp_enabled response from server

* update tests for test_hello

* update test utils

* Update mslib/msui/mscolab.py

Co-authored-by: Matthias Riße <[email protected]>

* fix typo

* move downed idp_enabled exception

* increase height ui_mscolab_connect_dialog

* resolve comments

---------

Co-authored-by: Matthias Riße <[email protected]>

* web browser implementation (#1814)

* web browser implementation

* update gitgnore

* resolve comments

* update docstring

* Configure mscolab for sso (#1818)

* db modeling

* add users into id[

* backend yaml implementation

* set server conf

* config server for sso

* qt ui implmentation

* backend html templates implementation

* update testcases

* config qt client app

* update gitignore

* set yaml endpoints

* update docs

* update test utill, and fix error

* fix test utils

* remove disabled pylint

* add libxmlsec1 into dep

* set IDP ENabled false

* Update mslib/mscolab/server.py

Co-authored-by: Matthias Riße <[email protected]>

* recorrect commit

* update db modeling with authentication_backend for multiple idps

* update conf for the multiple idps

* template implementation

* msui update redirect url for multiple idps

* saml update for multiple idps

* update mscolab server for multiple idps

* update doc for multiple idps

* automate CERTs generation and paths

* update doc

* correct typo in doc

* update doc

* fix typos update gitignore

* fix config idp_conf

* update gitignore

* set one time token access

* add params for cert creation

* set idp token for  one time validation

* fix  unnnescessary debug

* remove duplicate imports

* Update mslib/mscolab/mscolab.py

Co-authored-by: Matthias Riße <[email protected]>

* automate saml yaml file and improve error handling

* rename IDP_ENABLED to USE_SAML2

* update error template

* update doc

* add todo idp_wsgi

* update db models

* recorrect doc

* add todo refactors

---------

Co-authored-by: Matthias Riße <[email protected]>

* To do fixes #1818 (#1974)

* remove global var

* remove idp.subjects file dirs

* remove relaystste, rndstr and use secrets

* remove shell=True

* correct typos

* fix group order

* enable flake8 for GSOC2023-NilupulManodya

* fix lint

* fix lint

* fixes comments

* resolve comments

* fix comments

* update doc

* improve code for multiple Idps

* conf routes for multiple conf

* remove uncessary .yaml

* update cmd metadata

* update conf

* update saml handler for multiple idps

* pinning of xmlschema

* pin werkzeug

* disable pytests for todo refactor

* disbale whole file gsoc_testing

* fix conf

* resolve comments

* resolve comments

* manual conflict resolve ui_mscolab_connect_dialog.ui file

* resolve flake8

* set SSL certificate verification enablement (#2062)

* ssl verification enablement for SSO

* add hint

* Remove testing SP (#2066)

* remove testing sp

* remove documentation auth_client_sp

* Create documentation for SSO integration through SAML (#2064)

* create documentation sso integration

* added into makefile components

* change dir images

* resolve comments, add sample files

* resolve comments

* change cookies dir of web browser (#2063)

* change cookies dir of web browser

* Update mslib/msui/msui_web_browser.py

Co-authored-by: Matthias Riße <[email protected]>

---------

Co-authored-by: Matthias Riße <[email protected]>

* improve accessibility saml2 urls (#2068)

* improve accessibility saml2 urls

* resolve comments

---------

Co-authored-by: Nilupul Manodya <[email protected]>
Co-authored-by: Matthias Riße <[email protected]>
Co-authored-by: Matthias Riße <[email protected]>
Co-authored-by: nilupulmanodya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrss matrss matrss approved these changes

@ReimarBauer ReimarBauer ReimarBauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilupulmanodya @ReimarBauer @matrss