Reuse any existing QApplication instance in tests

According to my observations, also while trying to package MSS with nix,
this fixes the segmentation fault that can occur when running the tests.

tests/_test_msui/test_editor.py

@@ -43,7 +43,7 @@ class Test_Editor(object):
 
     @mock.patch("PyQt5.QtWidgets.QMessageBox.warning", return_value=QtWidgets.QMessageBox.Yes)
     def setup_method(self, mockmessage):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
 
         self.window = editor.EditorMainWindow()
         self.save_file_name = self.save_file_name

tests/_test_msui/test_kmloverlay_dockwidget.py

@@ -42,7 +42,7 @@
 class Test_KmlOverlayDockWidget(object):
 
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.view = mock.Mock()
         self.view.map = mock.Mock(side_effect=lambda x, y: (x, y))
         self.view.map.plot = mock.Mock(return_value=[mock.Mock()])

tests/_test_msui/test_linearview.py

@@ -44,7 +44,7 @@
 
 class Test_MSS_LV_Options_Dialog(object):
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.window = tv.MSUI_LV_Options_Dialog(settings=_DEFAULT_SETTINGS_LINEARVIEW)
         self.window.show()
         QtWidgets.QApplication.processEvents()
@@ -69,7 +69,7 @@ def test_get(self, mockcrit):
 
 class Test_MSSLinearViewWindow(object):
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         initial_waypoints = [ft.Waypoint(40., 25., 300), ft.Waypoint(60., -10., 400), ft.Waypoint(40., 10, 300)]
 
         waypoints_model = ft.WaypointsTableModel("")
@@ -118,7 +118,7 @@ def test_options(self, mockdlg, mockbox):
                     reason="multiprocessing needs currently start_method fork")
 class Test_LinearViewWMS(object):
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.port = PORTS.pop()
         self.tempdir = tempfile.mkdtemp()
         if not os.path.exists(self.tempdir):

tests/_test_msui/test_mscolab.py

@@ -62,7 +62,7 @@ def setup_method(self):
         self.user = get_user(self.userdata[0])
 
         QtTest.QTest.qWait(500)
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.main_window = msui.MSUIMainWindow(mscolab_data_dir=mscolab_settings.MSCOLAB_DATA_DIR)
         self.main_window.create_new_flight_track()
         self.main_window.show()
@@ -302,7 +302,7 @@ def setup_method(self):
         assert add_user_to_operation(path=self.operation_name3, access_level="collaborator", emailid=self.userdata3[0])
 
         QtTest.QTest.qWait(500)
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.window = msui.MSUIMainWindow(mscolab_data_dir=mscolab_settings.MSCOLAB_DATA_DIR)
         self.window.create_new_flight_track()
         self.window.show()

tests/_test_msui/test_mscolab_admin_window.py

@@ -68,7 +68,7 @@ def setup_method(self):
         assert add_user_to_operation(path="tokyo", emailid=self.userdata[0], access_level="creator")
 
         QtTest.QTest.qWait(500)
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.window = msui.MSUIMainWindow(mscolab_data_dir=mscolab_settings.MSCOLAB_DATA_DIR)
         self.window.create_new_flight_track()
         self.window.show()

tests/_test_msui/test_mscolab_merge_waypoints.py

@@ -51,7 +51,7 @@ def setup_method(self):
         handle_db_reset()
         self.process, self.url, self.app, _, self.cm, self.fm = mscolab_start_server(PORTS)
         QtTest.QTest.qWait(500)
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.window = msui.MSUIMainWindow(mscolab_data_dir=mscolab_settings.MSCOLAB_DATA_DIR)
         self.window.create_new_flight_track()
         self.emailid = '[email protected]'

tests/_test_msui/test_mscolab_operation.py

@@ -62,7 +62,7 @@ def setup_method(self):
         assert add_user_to_operation(path=self.operation_name, emailid=self.userdata[0])
         self.user = get_user(self.userdata[0])
         QtTest.QTest.qWait(500)
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.window = msui.MSUIMainWindow(mscolab_data_dir=mscolab_settings.MSCOLAB_DATA_DIR)
         self.window.create_new_flight_track()
         self.window.show()

tests/_test_msui/test_mscolab_version_history.py

@@ -55,7 +55,7 @@ def setup_method(self):
         assert add_user_to_operation(path=self.operation_name, emailid=self.userdata[0])
         self.user = get_user(self.userdata[0])
         QtTest.QTest.qWait(500)
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.window = msui.MSUIMainWindow(mscolab_data_dir=mscolab_settings.MSCOLAB_DATA_DIR)
         self.window.create_new_flight_track()
         self.window.show()

tests/_test_msui/test_mss.py

@@ -32,7 +32,7 @@
 
 @pytest.mark.skip(reason='needs review, assert missing')
 def test_mss_rename_message():
-    application = QtWidgets.QApplication(sys.argv)
+    application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
     main_window = mss.MSSMainWindow()
     main_window.show()
     QtTest.QTest.mouseClick(main_window.pushButton, QtCore.Qt.LeftButton)

tests/_test_msui/test_msui.py

@@ -68,7 +68,7 @@ def test_main():
 
 class Test_MSS_AboutDialog():
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.window = msui_mw.MSUI_AboutDialog()
 
     def test_milestone_url(self):
@@ -86,7 +86,7 @@ def teardown_method(self):
 
 class Test_MSS_ShortcutDialog():
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.main_window = msui_mw.MSUIMainWindow()
         self.main_window.show()
         self.shortcuts = msui_mw.MSUI_ShortcutsDialog()
@@ -154,7 +154,7 @@ def setup_method(self):
             os.path.dirname(os.path.abspath(__file__)),
             '../',
             'data/')
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
 
         self.window = msui.MSUIMainWindow()
         self.window.create_new_flight_track()

tests/_test_msui/test_multiple_flightpath_dockwidget.py

@@ -35,7 +35,7 @@
 class Test_MultipleFlightpathControlWidget():
 
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
 
         self.window = msui.MSUIMainWindow()
         self.window.create_new_flight_track()

tests/_test_msui/test_remotesensing.py

@@ -48,7 +48,7 @@ class Test_RemoteSensingControlWidget(object):
     Tests about RemoteSensingControlWidget
     """
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.view = Mock()
         self.map = qt.TopViewPlotter()
         self.map.init_map()

tests/_test_msui/test_satellite_dockwidget.py

@@ -34,7 +34,7 @@
 
 class Test_SatelliteDockWidget(object):
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.view = mock.Mock()
         self.window = sd.SatelliteControlWidget(view=self.view)
         self.window.show()

tests/_test_msui/test_sideview.py

@@ -45,7 +45,7 @@
 
 class Test_MSS_SV_OptionsDialog(object):
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.window = tv.MSUI_SV_OptionsDialog(settings=_DEFAULT_SETTINGS_SIDEVIEW)
         self.window.show()
         QtWidgets.QApplication.processEvents()
@@ -96,7 +96,7 @@ def test_setColour(self, mockdlg):
 
 class Test_MSSSideViewWindow(object):
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         initial_waypoints = [ft.Waypoint(40., 25., 300), ft.Waypoint(60., -10., 400), ft.Waypoint(40., 10, 300)]
 
         waypoints_model = ft.WaypointsTableModel("")
@@ -175,7 +175,7 @@ def test_y_axes(self, mockbox):
                     reason="multiprocessing needs currently start_method fork")
 class Test_SideViewWMS(object):
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.port = PORTS.pop()
         self.tempdir = tempfile.mkdtemp()
         if not os.path.exists(self.tempdir):

tests/_test_msui/test_suffix.py

@@ -35,7 +35,7 @@
 
 class Test_SuffixChange(object):
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.window = tv.MSUI_SV_OptionsDialog(settings=_DEFAULT_SETTINGS_SIDEVIEW)
         self.window.show()
         QtWidgets.QApplication.processEvents()

tests/_test_msui/test_tableview.py

@@ -38,7 +38,7 @@
 
 class Test_TableView(object):
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
 
         # Create an initital flight track.
         initial_waypoints = [ft.Waypoint(flightlevel=0, location="EDMO", comments="take off OP"),

tests/_test_msui/test_topview.py

@@ -45,7 +45,7 @@
 
 class Test_MSS_TV_MapAppearanceDialog(object):
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.window = tv.MSUI_TV_MapAppearanceDialog(settings=_DEFAULT_SETTINGS_TOPVIEW)
         self.window.show()
         QtWidgets.QApplication.processEvents()
@@ -72,7 +72,7 @@ def test_get(self, mockcrit):
 class Test_MSSTopViewWindow(object):
     def setup_method(self):
         mainwindow = MSUIMainWindow()
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         initial_waypoints = [ft.Waypoint(40., 25., 0), ft.Waypoint(60., -10., 0), ft.Waypoint(40., 10, 0)]
         waypoints_model = ft.WaypointsTableModel("")
         waypoints_model.insertRows(
@@ -299,7 +299,7 @@ def test_map_options(self, mockbox):
 class Test_TopViewWMS(object):
     def setup_method(self):
         self.port = PORTS.pop()
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
 
         self.tempdir = tempfile.mkdtemp()
         if not os.path.exists(self.tempdir):
@@ -361,7 +361,7 @@ def test_server_getmap(self, mockbox):
 
 class Test_MSUITopViewWindow():
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
 
     def test_kwargs_update_does_not_harm(self):
         initial_waypoints = [ft.Waypoint(40., 25., 0), ft.Waypoint(60., -10., 0), ft.Waypoint(40., 10, 0)]

tests/_test_msui/test_updater.py

@@ -83,7 +83,7 @@ def status_signal(s):
         self.updater.on_update_available.connect(update_signal)
         self.updater.on_status_update.connect(status_signal)
         self.updater.on_update_finished.connect(update_finished_signal)
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
 
     def teardown_method(self):
         self.application.quit()

tests/_test_msui/test_wms_capabilities.py

@@ -35,7 +35,7 @@
 class Test_WMSCapabilities(object):
 
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.capabilities = mock.Mock()
         self.capabilities.capabilities_document = u"Hölla die Waldfee".encode("utf-8")
         self.capabilities.provider = mock.Mock()

tests/_test_msui/test_wms_control.py

@@ -59,7 +59,7 @@ class WMSControlWidgetSetup(object):
     def _setup(self, widget_type):
         wc.WMS_SERVICE_CACHE = {}
         self.port = PORTS.pop()
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         if widget_type == "hsec":
             self.view = HSecViewMockup()
         else:
@@ -564,7 +564,7 @@ class TestWMSControlWidgetSetupSimple(object):
         <Extent name="ELEVATION" default="900.0"> 500.0,600.0,700.0,900.0 </Extent>"""
 
     def setup_method(self):
-        self.application = QtWidgets.QApplication(sys.argv)
+        self.application = QtWidgets.QApplication.instance() or QtWidgets.QApplication(sys.argv)
         self.view = HSecViewMockup()
         self.window = wc.HSecWMSControlWidget(view=self.view)
         self.window.show()