-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ffp class #8
Open
inkenbrandt
wants to merge
9
commits into
Open-ET:master
Choose a base branch
from
inkenbrandt:ffp-class
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ffp class #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made modifications to the example notebooks to improve readability and code execution. These changes improve code organization and module imports, and enhance the use case guide for the users. Fixed deprecation issues with the pyproj function calls. Created a Config file for US-CRT, and fixed custom variable additions.
Updates to notebooks
Made modifications to the example notebooks to improve readability and code execution. These changes improve code organization and module imports, and enhance the use case guide for the users. Fixed deprecation issues with the pyproj function calls. Created a Config file for US-CRT, and fixed custom variable additions.
Variable names within the FFPCalc class have been refactored to be singular rather than plural, enhancing readability. Colormap handling has been modified to use direct matplotlib colormap access instead of the "cm" module. Smooth kernel declaration has been changed from matrix to an array to ensure proper data format compatibility.
This commit introduces a script for parallel processing preformatted time series input data needed for the Kljun et al. 2D flux footprint prediction code. It includes data checks, automatic download, and weighted data normalization. Intended for scientific purposes to document employed workflows.
This commit introduces a script for parallel processing preformatted time series input data needed for the Kljun et al. 2D flux footprint prediction code. It includes data checks, automatic download, and weighted data normalization. Intended for scientific purposes to document employed workflows.
… on making better tests).
The ffp.py file was refactored, notably changing how matplotlib is imported and how certain calculations are performed. A new unit test file, test_ffp.py, was added to verify correct behavior after the refactor. Additionally, small changes were also made to a jupyter notebook to match with the current ffp.py state.
The ffp.py file was refactored, notably changing how matplotlib is imported and how certain calculations are performed. A new unit test file, test_ffp.py, was added to verify correct behavior after the refactor. Additionally, small changes were also made to a jupyter notebook to match with the current ffp.py state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the issues with the ffp class and updated some tests.
Refactor ffp.py and add associated tests
The ffp.py file was refactored, notably changing how matplotlib is imported and how certain calculations are performed. A new unit test file, test_ffp.py, was added to verify correct behavior after the refactor. Additionally, small changes were also made to a jupyter notebook to match with the current ffp.py state.