-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comparison processes read 4-digit values as EPSG, change them wrongfully #157
Comments
Yeah, the issue that another data type is "chosen" is not really possible to fix. It also applies to other data types. The issue is that just from the value (e.g. 4000) I can't detect which "visualization" to choose. I should probably fall back to the "native" one (e.g. number instead of EPSG) by default, but it will never be "exact". Then there will be cases where an EPSG code is identified just as a number... What I can surely fix that EPSG:4000 is chosen (if it exists) instead of 2000... |
Why allow EPSGs at all? |
Any data type is allowed so why restrict? I can't guess what the user wants to input... |
True. Why is any data type allowed, given the documentation:
? I don't wanna pry too much here, I just fail to imagine any use case. Here's an idea: The menu gets a neutral option like "-Select type-". Whenever process options are opened, this "-Select type-" is shown in |
Okay, there were two issues here:
So the behavior should have improved in v0.7.7. PS: Any data type is allowed to allow conditions to always return a result without throwing an error. |
Thanks! That makes a lot of sense.
I realize now that with this fixed, the shown type is not as important anymore as values themselves aren't changed anymore. Other improvement sounds great though too! 👍 |
Consider the following to reproduce: Web Editor -> open a process
lt
,gte
or the likes, aty
parameter select typenumber
and enter4000
, clicksave
, open the process again, nowtype
isEPSG
and the first in the selection list isEPSG:2000
, click save, now the value fory
is2000
. As far as I can tell only 4 digit values and processeslt
,lte
,gte
andgt
are affected, didn't test all combinations though, i.e. only had a look atadd
anddivide
to confirm this is not affecting other math processes. (All while connected to VITO backend).The text was updated successfully, but these errors were encountered: