Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating, changing and saving jobs on VITO backend doesn't work #55

Closed
jonathom opened this issue Nov 18, 2020 · 7 comments
Closed

creating, changing and saving jobs on VITO backend doesn't work #55

jonathom opened this issue Nov 18, 2020 · 7 comments

Comments

@jonathom
Copy link
Member

There seems to be a problem with the creation and the change of jobs on the VITO backend (via online editor). I am not able to save process graphs as new batch jobs or to change existing jobs (404 error). This seems to be a new or recurring issue since I was still able to do so just a week ago.

Job creation/change on another backend still works in the editor (GEE tested). Also, upon starting a job via R-client it is successfully registered on the backend (VITO).

On a second note, giving titles to jobs never seemed to work for me, no matter what client was used.

Please let me know if I should move this to another repository.

@soxofaan
Copy link
Member

I think this is caused by #54 : js client can not extract "openeo-identifier" from /jobs POST response because of CORS issues.
The batch job should be stored however, so if you reload the online editor, it should be listed under batch jobs. can you confirm?

About the other issue: we indeed don't store or return the job's title yet. I'll have a look if that can be resolved easily

@jonathom
Copy link
Member Author

yes, the job is indeed saved and visible upon reloading. Thank you.

However job edits and changes are not stored even upon reloading.

@soxofaan
Copy link
Member

thanks for confirming

indeed, the VITO backend currently does not support modifying batch jobs -> #56
the error message shows this:
Screenshot from 2020-11-19 11-57-50

@m-mohr would it be easy to disable the "save" button when backend does not support updates?

@m-mohr
Copy link
Member

m-mohr commented Nov 19, 2020

I'll check: Open-EO/openeo-web-editor#128

@m-mohr
Copy link
Member

m-mohr commented Nov 19, 2020

@soxofaan Your suggestion has been implemented and released as v0.5.2, can now be tested at https://editor.openeo.org/

soxofaan added a commit that referenced this issue Nov 30, 2020
- Implement API 1.0.1 CORS recommendation (Open-EO/openeo-api#41)
- Address both OPTIONS and non-OPTIONS requests properly
- Fixes #54, #55
- add more unit tests
@soxofaan
Copy link
Member

CORS issue (#54) should be fixed with next prod deploy of VITO backend (somewhere this week probably)

@soxofaan
Copy link
Member

soxofaan commented Nov 3, 2021

I think this can be closed
#56 is follow up issue

@soxofaan soxofaan closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants