Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/service_types: skip backend when its capabilities states it does not support /service_types #85

Closed
JohanKJSchreurs opened this issue Dec 7, 2022 · 4 comments
Closed

/service_types: skip backend when its capabilities states it does not support /service_types #85

JohanKJSchreurs opened this issue Dec 7, 2022 · 4 comments
Assignees
@JohanKJSchreurs
Labels
federation design performance

Comments

@JohanKJSchreurs
Copy link
Contributor

JohanKJSchreurs commented Dec 7, 2022 •
edited
Loading

EODC backend (e.g.) does not support /service_types and we can know that beforehand (because it's not in capabilities doc), so we should skip it, instead of trying and needlessly logging a 404 error.

This is a follow up ticket for the to do's of #78, to plan and track the tasks separately .
See also: #78 (comment)
@soxofaan soxofaan mentioned this issue Dec 7, 2022
Closed
@soxofaan
Copy link
Member

soxofaan commented Dec 7, 2022

FYI: VITO back-end also stopped supporting /service_types since Open-EO/openeo-geopyspark-driver@c61b822 (I'm not sure if this change is in production already)

@soxofaan
Copy link
Member

soxofaan commented Dec 7, 2022

some info:

Start from a MultiBackendConnection and iterate through the upstream backends (BackendConnection objects), each of these has a capabilities() method, which returns an RESTCapabilities object. From that you should be able to check with supports_endpoint if /service_types is supported

@soxofaan
Copy link
Member

soxofaan commented Dec 7, 2022

another thing: I think it makes sense to store the result of this check in the housekeeping structure mentioned in #84 in some way

@JohanKJSchreurs JohanKJSchreurs mentioned this issue Dec 9, 2022
Merged
JohanKJSchreurs added a commit that referenced this issue Dec 13, 2022
@JohanKJSchreurs
Issue #85: Implemented skipping backends that don't support GET /serv…
f03ab14 
…ice_types
JohanKJSchreurs added a commit that referenced this issue Dec 13, 2022
@JohanKJSchreurs
Issue #85, Fix test and add test coverage for _get_supported_backends
f7ba403
JohanKJSchreurs added a commit that referenced this issue Dec 13, 2022
@JohanKJSchreurs
Issue #85, Run pre-commit / linter
e802941
JohanKJSchreurs added a commit that referenced this issue Dec 13, 2022
@JohanKJSchreurs
Issue #85 Clarified some comments
2de936f
@JohanKJSchreurs JohanKJSchreurs mentioned this issue Dec 13, 2022
Merged
JohanKJSchreurs added a commit that referenced this issue Dec 14, 2022
@JohanKJSchreurs
Issue #85 Cached supported backends together with other info about se…
8f51fa1 
…rvice_types
JohanKJSchreurs added a commit that referenced this issue Dec 14, 2022
@JohanKJSchreurs
Issue #85 Make a few names, comments and some code more clear.
4af81b7
JohanKJSchreurs added a commit that referenced this issue Jan 11, 2023
@JohanKJSchreurs
#85 Code review: small changes to make things more readable
a9d6bb4
JohanKJSchreurs added a commit that referenced this issue Jan 11, 2023
@JohanKJSchreurs
#85 Code review: converted simple fixtures to constants
f1c029c
JohanKJSchreurs added a commit that referenced this issue Jan 12, 2023
@JohanKJSchreurs
#85 Code review: more logical order of request mocks
ce0af7c
JohanKJSchreurs added a commit that referenced this issue Jan 12, 2023
@JohanKJSchreurs
#85 Code review: use dummy names and references in test data
526cca9
JohanKJSchreurs added a commit that referenced this issue Jan 18, 2023
@JohanKJSchreurs
#85 Code review: remove unnecessary mock from test
ad0ab9c
soxofaan added a commit that referenced this issue Jan 18, 2023
@soxofaan
Fixup CHANGELOG.md a bit
165cab7 
related to #78 #84, #85
@soxofaan
Copy link
Member

#87 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohanKJSchreurs JohanKJSchreurs

Labels
federation design performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soxofaan @JohanKJSchreurs