Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation of collections #5

Closed
soxofaan opened this issue Aug 25, 2021 · 6 comments
Closed

Federation of collections #5

soxofaan opened this issue Aug 25, 2021 · 6 comments

Comments

@soxofaan
Copy link
Member

The aggregator combines multiple back-ends, each of which support different collections, as exposed by their respective GET /collections listings.

The aggregator's /collections currently returns the union of the collections.
Duplicates (same collection id on different back-ends) are currently removed from the union however.

This ticket is for tracking questions and concerns about the strategy of merging collection listings

@jdries
Copy link
Contributor

jdries commented Jan 13, 2022

isn't this at least partially solved by the effort on harmonizing collections and allowing to specify a preferred backend in load_collection?

@soxofaan
Copy link
Member Author

yes that's part of this issue

@soxofaan
Copy link
Member Author

FYI: since f1bfb44 (sept 2021) the aggregator's /collections will also return collections present on multiple back-ends.
The basic merging of metadata is there, but there are still some todo's left, for example from AggregatorCollectionCatalog._merge_collection_metadata:

        # TODO: better merging of title and description?
        # TODO: smarter version maximum?
        # TODO: .. "various" if multiple licenses apply ... links to the license texts SHOULD be added,
        # TODO  cube_dimensions = getter.get("cube:dimensions") ...
        # TODO merge existing summaries?
        # TODO: assets ?

@soxofaan
Copy link
Member Author

soxofaan commented Aug 4, 2022

I think this is a good first issue for @JeroenVerstraelen to dive in the implementation of openeo-aggregator

@soxofaan
Copy link
Member Author

https://github.com/openEOPlatform/architecture-docs/issues/260 also lists a couple of TODO's for collection metadata merging:

Metadata that is not copied/merged correctley:

@JeroenVerstraelen JeroenVerstraelen linked a pull request Aug 22, 2022 that will close this issue
soxofaan added a commit that referenced this issue Sep 16, 2022
soxofaan added a commit that referenced this issue Sep 16, 2022
soxofaan added a commit that referenced this issue Sep 16, 2022
soxofaan pushed a commit that referenced this issue Sep 16, 2022
soxofaan pushed a commit that referenced this issue Sep 16, 2022
soxofaan pushed a commit that referenced this issue Sep 16, 2022
soxofaan pushed a commit that referenced this issue Sep 16, 2022
soxofaan pushed a commit that referenced this issue Sep 16, 2022
soxofaan pushed a commit that referenced this issue Sep 16, 2022
@jdries
Copy link
Contributor

jdries commented Mar 8, 2023

issue was done some time ago, but not closed, closing now!

@jdries jdries closed this as completed Mar 8, 2023
soxofaan added a commit to Open-EO/openeo-python-driver that referenced this issue Sep 20, 2023
(feature moved from aggregator, originally introduced under Open-EO/openeo-aggregator#5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants