-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved node descriptions for IntelliSense #1866
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also suggest revising the final dot .
in all descriptions and make it consistent.
}, | ||
"ProcessorDsp": { | ||
"enum": [ "on", "off" ], | ||
"description": "Controls usage of DSP: on (enabled) | off (disabled)" | ||
"description": "Controls usage of SIMD instructions:\n on (enabled) | off (disabled) ." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dsp
node concerns DSP extensions, for example disabling the DSP for Cortex-M33 will result in the following AC6 flag: -mcpu=Cortex-M33+nodsp
SIMD flags such as -fvectorize
are not yet abstracted via dedicated yaml nodes.
"description": "Controls usage of SIMD instructions:\n on (enabled) | off (disabled) ." | |
"description": "Controls usage of DSP extensions:\n on (enabled) | off (disabled) ." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation mentions SIMD. Agree that "DSP" itself has not so clear definition in this context. Then documentation would need to explain what it means for what CPUs. Maybe https://github.com/Open-CMSIS-Pack/cmsis-toolbox/blob/main/docs/YML-Input-Format.md#processor
I changed to have end the descriptions with a dot. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
=======================================
Coverage 64.95% 64.95%
=======================================
Files 163 163
Lines 34552 34552
Branches 20043 20043
=======================================
Hits 22442 22442
Misses 7959 7959
Partials 4151 4151
Flags with carried forward coverage won't be shown. Click here to find out more. |
No description provided.