-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpackget] refined --skip-touch option #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 79.00% 78.93% -0.07%
==========================================
Files 22 22
Lines 2572 2583 +11
==========================================
+ Hits 2032 2039 +7
- Misses 399 403 +4
Partials 141 141
☔ View full report in Codecov by Sentry. |
bgn42
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
soumeh01
reviewed
Jun 28, 2023
--skip-touch originated from PackUnzip where it had the same functionality and there also was no short option. Also, this is an internal option not used directly by a user.
Von: Sourabh Mehta ***@***.***>
Gesendet: Mittwoch, 28. Juni 2023 16:08
An: Open-CMSIS-Pack/cpackget ***@***.***>
Cc: Bernd-Gunter Nitzler ***@***.***>; Review requested ***@***.***>
Betreff: Re: [Open-CMSIS-Pack/cpackget] [cpackget] refined --skip-touch option (PR #190)
@soumeh01 commented on this pull request.
________________________________
In cmd/commands/init.go<#190 (comment)>:
@@ -53,4 +57,5 @@ The index-url is mandatory. Ex "cpackget init --pack-root path/to/mypackroot htt
func init() {
InitCmd.Flags().BoolVarP(&initCmdFlags.downloadPdscFiles, "all-pdsc-files", "a", false, "downloads all the latest .pdsc files from the public index")
InitCmd.Flags().BoolVarP(&initCmdFlags.encodedProgress, "encoded-progress", "E", false, "Reports encoded progress for files and download when used by other tools")
+ InitCmd.Flags().BoolVar(&initCmdFlags.skipTouch, "skip-touch", false, "do not touch pack.idx")
can you confirm if this needs only long options --skip-touch and no short option?
—
Reply to this email directly, view it on GitHub<#190 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWCKMYDJYIL5TQRAGOITGCTXNQ3CXANCNFSM6AAAAAAZXE2ENY>.
You are receiving this because your review was requested.Message ID: ***@***.******@***.***>>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
|
soumeh01
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added option also to other commands touching pack.idx