Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save group chat repeat #977

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: save group chat repeat #977

merged 1 commit into from
Sep 25, 2023

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented Sep 24, 2023

Fixes #

Proposed Changes

@vi-sudo
Copy link

vi-sudo commented Sep 24, 2023

@what-the-diff
Copy link

what-the-diff bot commented Sep 24, 2023

PR Summary

  • Optimized Code for React App
    New changes were made to further optimize the code of our React application. Numerous variables have been adjusted to use React's useMemo function. This helps in optimizing our resource utilization by remembering costly computations and only re-computing as needed.

  • Improved Function Implementations Using Hooks
    Certain functions such as getSessionListTab, createGroupChat, updateGroupChatSettings, handleCreateAndUpdateButton, and handleOverlayAction have been revamped using the useCallback hook instead of regular functions. These changes make the application's functions more efficient and easier to maintain.

  • Simplified Dependencies
    The variable selectedRepetitive was removed from the dependencies array of the getOptionOfSelectedDuration function. It simplifies the complexity of the dependency chain providing more simplified code to work with.

  • Minor HTML Correction
    Fixed a small issue with the HTML where a closing tag for a div element was missing. This ensures that our code follows correct HTML standards and prevents potential isues in layout rendering.

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-mi web-mi merged commit ab64f2e into develop Sep 25, 2023
8 checks passed
@web-mi web-mi deleted the OB-6769 branch September 25, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants