Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x.x] Add release workflow github action #1496

Open
wants to merge 1 commit into
base: player-model-main
Choose a base branch
from

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Oct 8, 2024

Description

One Line Summary

Action for building the release binaries and updating the Package.swift for a release

Details

Adapted from the workflow on main.

This action is intended to

  1. build the binaries needed for an iOS release
  2. Code sign the frameworks
  3. Update the swift package
  4. open a PR with the changes.

It does NOT

  1. bump version numbers
  2. write release notes
  3. Create the Github Release after merging the pr
  4. Distribute the Cocoapod

How to use this action:

  1. Create a release branch with the bumped version numbers and push it.
  2. Kick-off the action from the actions tab of the Github repo specifying the version number and release branch
  3. Once the action has completed and created the PR write the release notes in the body of the PR and assign reviewers.

Motivation

Improve the release process

Manual testing

Released 3.12.10 with this action.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li requested a review from emawby October 8, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant